-
Couldn't load subscription status.
- Fork 9
fix: convert references to absolute paths for proper parent directory handling and deduplication #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TristanSpeakEasy
merged 3 commits into
main
from
fix/absolute-reference-handling-and-refactoring
Oct 13, 2025
Merged
fix: convert references to absolute paths for proper parent directory handling and deduplication #58
TristanSpeakEasy
merged 3 commits into
main
from
fix/absolute-reference-handling-and-refactoring
Oct 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling and deduplication
📊 Test Coverage ReportCurrent Coverage: Coverage Change: 📈 +.1% (improved) Coverage by Package
Generated by GitHub Actions |
BlakeTheAwesome
requested changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #50 - Parent directory references (
../) were not being bundled correctly during the bundling process.Problem
When bundling OpenAPI documents with references using parent directory notation (e.g.,
../common.yaml#/components/schemas/Schema), these references were not being properly resolved and bundled. Instead, they remained as../references in the output, which breaks the bundled document.This was reported by @vincentserpoul with a reproducible example.
Solution
Modified
handleReference()to convert ALL references (internal, external, and parent directory) to absolute paths before tracking them. This ensures:../references are properly resolved to their absolute pathsChanges
Core Fix
handleReference()now converts all references to absolute paths using filepath operationsCode Quality Improvements (DRY/YAGNI)
isInternalReference()helper - eliminates ~22 lines of duplicationextractSimpleNameFromReference()helper - eliminates ~60 lines of duplicationfindCircularReferenceMatch()helper - eliminates ~26 lines of duplicationparentLocationparameter (~110 lines total reduction)Test Results
✅ All bundle and inline tests passing (8/8)
✅ New comprehensive test case for issue #50 passing
Test Case
Added
TestBundle_Issue50_Successwith test data from the issue reproducer, covering:../common.yaml,../country.yaml)